jpountz commented on code in PR #13550:
URL: https://github.com/apache/lucene/pull/13550#discussion_r1668890679
##########
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseDocValuesFormatTestCase.java:
##########
@@ -157,6 +158,7 @@ public void testNumberMergeAwayAllValuesWithSkipper()
throws IOException {
Analyzer analyzer = new MockAnalyzer(random());
IndexWriterConfig iwconfig = newIndexWriterConfig(analyzer);
iwconfig.setMergePolicy(newLogMergePolicy());
+ iwconfig.setCodec(SkipperCodec.randomInstance(random()));
Review Comment:
This doesn't look right, as this overrides the codec that is configured on
the test case, e.g. `SimpleTextDocValuesFormat` would no longer be exercised?
Should we create a new `TestLucene90DocValuesFormatVariableSkipInterval` class
or something along these lines instead?
##########
lucene/test-framework/src/java/org/apache/lucene/tests/codecs/skipper/SkipperCodec.java:
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.tests.codecs.skipper;
+
+import java.util.Random;
+import org.apache.lucene.codecs.DocValuesFormat;
+import org.apache.lucene.codecs.FilterCodec;
+import org.apache.lucene.codecs.lucene90.Lucene90DocValuesFormat;
+import org.apache.lucene.tests.util.TestUtil;
+
+/**
+ * A codec that uses {@link Lucene90DocValuesFormat} with a random skip index
size for its doc
+ * values and delegates to the default codec for everything else.
+ */
+public final class SkipperCodec extends FilterCodec {
Review Comment:
Maybe rename to `Skipper90Codec` to reflect that it maps to
`Lucene90DocValuesFormat`? I assume we'd create a new one when we release a new
DV format?
Also, does it need to be a new Codec, or could it extend `Lucene911Codec`
and override `getDocValuesFormatForField`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
