cpoerschke commented on code in PR #13525: URL: https://github.com/apache/lucene/pull/13525#discussion_r1664549231
########## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java: ########## @@ -143,14 +143,22 @@ public int nextDoc() throws IOException { public static final class MergedVectorValues { private MergedVectorValues() {} + private static void validateFieldEncoding(FieldInfo fieldInfo, VectorEncoding expected) { Review Comment: Seeing this method being factored out here inspired me to try and see if more duplication could be removed: pr-link-to-follow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org