original-brownbear commented on code in PR #13472:
URL: https://github.com/apache/lucene/pull/13472#discussion_r1631773583
##########
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##########
@@ -112,15 +102,10 @@ RunnableFuture<T> createTask(Callable<T> callable) {
() -> {
if (startedOrCancelled.compareAndSet(false, true)) {
try {
- Integer counter = numberOfRunningTasksInCurrentThread.get();
Review Comment:
I now read some of the previous discussion on this. We could bring this back
if we wanted to avoid 2nd level fan-out for tasks, but it's not necessary for
dead-lock avoidance. Also, for CPU bound small tasks from another layer of
fanning out the loop on the calling thread should offer similar or better
performance relative to just not fanning out again for most cases IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
