stefanvodita commented on code in PR #13419:
URL: https://github.com/apache/lucene/pull/13419#discussion_r1619067114
##########
lucene/core/src/test/org/apache/lucene/analysis/TestWordlistLoader.java:
##########
@@ -77,4 +82,17 @@ public void testSnowballListLoading() throws IOException {
assertTrue(wordset.contains("six"));
assertTrue(wordset.contains("seven"));
}
+
+ public void testGetLines() throws IOException {
+ String s = "One \n#Comment \n \n Two \n Three \n";
+ Charset charset = StandardCharsets.UTF_8;
+ byte[] sByteArr = s.getBytes(charset);
+ InputStream sInputStream = new ByteArrayInputStream(sByteArr);
+ List<String> lines = WordlistLoader.getLines(sInputStream, charset);
+ assertEquals(3, lines.size());
+ assertFalse(lines.contains("#Comment"));
Review Comment:
Nit: The other asserts, taken together, already make a stronger guarantee
about this comment than this assert, making it a bit redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
