jpountz commented on code in PR #13421:
URL: https://github.com/apache/lucene/pull/13421#discussion_r1615559343
##########
lucene/core/src/test/org/apache/lucene/index/TestOrdinalMap.java:
##########
@@ -52,7 +53,9 @@ public long accumulateObject(
long shallowSize,
java.util.Map<Field, Object> fieldValues,
java.util.Collection<Object> queue) {
- if (o == LongValues.ZEROES || o == LongValues.IDENTITY) {
+ if (o == LongValues.ZEROES
+ || o == LongValues.IDENTITY
+ || o ==
PackedInts.NullReader.DEFAULT_PACKED_LONG_VALUES_PAGE_SIZE) {
Review Comment:
Nit: Can you replace this with
`PackedInts.NullReader.forCount(PackedLongValues.DEFAULT_PAGE_SIZE)` and make
`DEFAULT_PACKED_LONG_VALUES_PAGE_SIZE` private again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
