shatejas commented on code in PR #13407:
URL: https://github.com/apache/lucene/pull/13407#discussion_r1613901301
##########
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##########
@@ -54,14 +54,20 @@ abstract class AbstractKnnVectorQuery extends Query {
protected final String field;
protected final int k;
+ protected final int efSearch;
private final Query filter;
- public AbstractKnnVectorQuery(String field, int k, Query filter) {
+ public AbstractKnnVectorQuery(String field, int k, int efSearch, Query
filter) {
Review Comment:
We are forcing the user to think about what efSearch value should be. The
existing implementations of this abstract class are updated to keep using k as
the efSearch value to maintain backward compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
