dweiss commented on code in PR #13406:
URL: https://github.com/apache/lucene/pull/13406#discussion_r1612106758
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/core/FlattenGraphFilter.java:
##########
@@ -349,7 +350,7 @@ public boolean incrementToken() throws IOException {
* The last node in the alt path didn't arrive to remove this
reference.
*/
assert inputNodes.get(inputFrom).tokens.isEmpty() : "about to
remove non empty edge";
- outSrc.inputNodes.remove(Integer.valueOf(inputFrom));
+ outSrc.inputNodes.remove(inputFrom);
Review Comment:
I wonder if it makes sense to rename this early to "removeElement", in the
spirit of changes coming to HPPC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
