mikemccand commented on issue #13350: URL: https://github.com/apache/lucene/issues/13350#issuecomment-2122686859
Thank you @naveentatikonda for the deep dive here and a nice unit test ... I couldn't follow all of the logic you described, but if we are indeed first normalizing a dimension's value `v` to a float `[0 .. 255]` and then simply `(byte) Math.round(v)` for the signed byte (`int8`) case, then that does indeed sound wrong. We should instead normalize the `float v` to `[-128 .. 127]`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
