iamsanjay opened a new pull request, #13390:
URL: https://github.com/apache/lucene/pull/13390
### Description
#13112
Made fields final and removed their respective setters. Introduced the
Builder pattern to facilitate the construction of ShingleFilter instances. All
previous ctors have been removed and replaced with a new one that accepts a
Builder object as an input parameter (Used @IgnoreRandomChains to pass the test
for now).
Since ctors were removed, an entry in MIGRATE.md is necessary, as
Elasticsearch relies on this class, according to a GitHub search.
If the Builder pattern is not preferred, we could discard this approach and
consider using chaining constructors instead.
<!--
If this is your first contribution to Lucene, please make sure you have
reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
