zkendall commented on code in PR #13384:
URL: https://github.com/apache/lucene/pull/13384#discussion_r1606204717
##########
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java:
##########
@@ -1422,7 +1422,7 @@ public Analyzer getWrappedAnalyzer(String fieldName) {
Set.of("field_tripples", "field_characters"),
"danc",
"<b>danc</b>e with star",
- "<b>da</b><b>n</b><b>c</b>e with star");
+ "<b>dan</b><b>c</b>e with star");
Review Comment:
This test is of "every character" is a token AND "every _three_ characters
is a token".. So it's clear that "dan" is a better highlight than "da" and "n"
separate.
##########
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java:
##########
@@ -1422,7 +1422,7 @@ public Analyzer getWrappedAnalyzer(String fieldName) {
Set.of("field_tripples", "field_characters"),
"danc",
"<b>danc</b>e with star",
- "<b>da</b><b>n</b><b>c</b>e with star");
+ "<b>dan</b><b>c</b>e with star");
Review Comment:
This test is of "every character" is a token AND "every _three_ characters
is a token".. So "dan" is a better highlight than "da" and "n" separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
