timgrein commented on PR #13383: URL: https://github.com/apache/lucene/pull/13383#issuecomment-2119285328
> I don't really like that we have to expose these internal classes purely to do class casts. I kinda oriented myself at `LongValueSource.ConstantLongValuesSource`, which is also `public` and used in a similar way [here](https://github.com/apache/lucene/blob/7db9c8c9bda7452232c329db2ad6df90bdcd4a37/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CoveringQuery.java#L129), but I'll check, if there's a better way without making the classes public. > I wonder if we could add some kind of check ValuesSource.minValue/maxValue or ValuesSource.isRangeComplete or so that could be used more generically I think `ValueSource` is extended by `LongFieldSource`, which seems to have similar semantics as `FieldValueSource` inside `LongValueSource`, but it's not used inside `LongRange` ... 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
