gf2121 commented on code in PR #13221:
URL: https://github.com/apache/lucene/pull/13221#discussion_r1601216937
##########
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##########
@@ -207,102 +208,91 @@ private void updateCompetitiveIterator() throws
IOException {
|| hitsThresholdReached == false
|| (leafTopSet == false && queueFull == false)) return;
// if some documents have missing points, check that missing values
prohibits optimization
- if ((pointValues.getDocCount() < maxDoc) && isMissingValueCompetitive())
{
+ boolean dense = pointValues.getDocCount() == maxDoc;
+ if (dense == false && isMissingValueCompetitive()) {
return; // we can't filter out documents, as documents with missing
values are competitive
}
- updateCounter++;
- // Start sampling if we get called too much
- if (updateCounter > 256
- && (updateCounter & (currentSkipInterval - 1)) !=
currentSkipInterval - 1) {
+ if (competitiveIterator instanceof CompetitiveIterator iter) {
+ if (queueFull) {
+ encodeBottom();
+ }
+ // CompetitiveIterator already built, try to reduce clause.
+ tryReduceDisjunctionClause(iter);
return;
}
- if (queueFull) {
- encodeBottom();
+ if (thresholdAsLong == -1) {
+ if (dense == false) {
+ competitiveIterator = getNumericDocValues(context, field);
+ leadCost = Math.min(leadCost, competitiveIterator.cost());
+ }
+ long threshold = Math.min(leadCost >> 3, maxDoc >> 5);
+ thresholdAsLong = intersectThresholdValue(threshold);
Review Comment:
Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
