zhongshanhao commented on code in PR #13343:
URL: https://github.com/apache/lucene/pull/13343#discussion_r1592847407


##########
lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionScorer.java:
##########
@@ -115,6 +115,10 @@ private void moveToNextBlock(int target) throws 
IOException {
       }
 
       private int advanceTarget(int target) throws IOException {
+        if (minScore <= 0) {
+          return target;

Review Comment:
   Oh, I got it. It is necessary to maintain that invariant that `doc < upTo`. 
The role of this variable `upTo`  is clear. `upTo` will always be boundaries of 
the lead scorer, Or we should `moveToNextBlock`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to