uschindler commented on PR #13337: URL: https://github.com/apache/lucene/pull/13337#issuecomment-2096310679
> Thanks for taking a look Uwe, and suggesting approaches for the page size issue! By the way, feel free to push directly to the branch. > > > I also have some questions about the NIOFS one because I don't like to use twice as much file handles just for the prefetching. > > I don't like it either. And actually tests don't like it either, as I've seen more issues with `HandleLimitFS` due to this change. :) Can't we use the same filechannel and do a positional read in another thread (not async)? I like the trick to use a virtual thread, because by that we have no additional thread and instead it hooks into the next I/O call and triggers our read. As this is the case, what's the problem of doing a blocking call (positional) in the virtual thread? If the virtual thread gets blocked it will hand over the call to another virtual thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
