uschindler commented on PR #13329: URL: https://github.com/apache/lucene/pull/13329#issuecomment-2085449503
> Nice! This is neat. Thank you Uwe! > > I think this takes care of record ctors along with synthetic methods due to `ExecutableElement.getEnclosingElement().getEnclosedElements()` returning ctor also as enclosed element in `Elements#recordComponentFor`? No, the ctors are excluded because of the first if statement. Actually regarding the comment "UweSays: It should not happen but it happens!" the following if statements should be all not needed (because the elements are not explicit - but mandated - it still reports them. In short: - `Elements#recordComponentFor` tests every method if it is the accessor of a record component, if it returns something != null, we can exclude it - `Elements#getOrigin(element) != Origin.EXPLICIT` finds all ctors which are not declared -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
