s1monw commented on code in PR #13324:
URL: https://github.com/apache/lucene/pull/13324#discussion_r1584305983
##########
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##########
@@ -6128,7 +6128,7 @@ public final int numDeletesToMerge(SegmentCommitInfo
info) throws IOException {
ensureOpen(false);
validate(info);
MergePolicy mergePolicy = config.getMergePolicy();
- final ReadersAndUpdates rld = getPooledInstance(info, false);
+ final ReadersAndUpdates rld = getPooledInstance(info, true);
Review Comment:
I just re-read the change that I made that added this comment and I think
it's not allowed to pull a reader here if it's not already visible. I don't
recall the side-effects of this but I am sure there are some. To me the test
seems to be artificial since it's really just testing if that works on fresh
writer?! I am not against the change I just think we need more coverage for
this to ensure it's not triggering the same issues that caused the change in
the first place?
I think IW should be very conservative here with pulling memory for segments
that are not in memory yet.
Yet, the comment basically means that we can't return the soft del count
since it might overcommit because of it's nature of being dynamic based on the
MP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
