mikemccand commented on PR #13045: URL: https://github.com/apache/lucene/pull/13045#issuecomment-2049567118
I think this is a reasonable hook to add, but could you maybe add javadocs to the new protected method? Maybe something like: ``` /** Applications can subclass and override this method to customize what it stored in commitData for each commit. */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org