DaveCTurner commented on issue #13275:
URL: https://github.com/apache/lucene/issues/13275#issuecomment-2039959127
In particular I'm a little suspicious about the way we call
`org.apache.lucene.index.IndexFileDeleter#incRef(org.apache.lucene.index.SegmentInfos,
boolean)` _after_ doing the rename and setting `commitCompleted = true`, all
within a `try (Closeable finalizer = () -> deleter.decRef(commitFiles)) {...}`
block. Are we sure it's ok if an exception is thrown just before that
`incRef()` call? Is there something else preventing those files from being
`decRef`'d into the void? Sorry if this is a red herring, I don't spend much
time in this code so I don't have all the relevant invariants in my head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
