antonha commented on PR #13149: URL: https://github.com/apache/lucene/pull/13149#issuecomment-2028487168
Thank you all for helping to get this PR into a better state. The only thing that still irked me is that I couldn't get the tests to execute all newly added methods. I made a few changes in the [last commit](https://github.com/apache/lucene/pull/13149/commits/cc39cc1afb32a49b83a9557a31835d93ce152ef8) to: - Add a new test case which calls `doTestRandomLongs` with 20 000 - without this I couldn't get the IntsRef to trigger often enough. This should maybe be a `@Nightly`? - Added a higher chance of having 0 missing values in `doTestRandomLongs` - otherwise the inverse intersect visitor would only have a chance of happening every 100 runs, which I thought a bit low. I would love it if you, @mikemccand or @jpountz, could give a thumbs up to these last changes? After this, what's the protocol? Do I merge the PR myself or should a committer push the button? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
