jpountz commented on code in PR #13237: URL: https://github.com/apache/lucene/pull/13237#discussion_r1544264043
########## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ########## @@ -200,9 +200,18 @@ private VectorSimilarityFunction readSimilarityFunction(DataInput input) throws return VectorSimilarityFunction.values()[similarityFunctionId]; } - private FieldEntry readField(DataInput input) throws IOException { + private FieldEntry readField(IndexInput input, FieldInfo info) throws IOException { VectorSimilarityFunction similarityFunction = readSimilarityFunction(input); - return new FieldEntry(input, similarityFunction); + if (similarityFunction != info.getVectorSimilarityFunction()) { + throw new IllegalStateException( Review Comment: We usually throw `CorruptIndexException` for such inconsistencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org