jpountz commented on PR #13219: URL: https://github.com/apache/lucene/pull/13219#issuecomment-2020941392
> The question that I have about this: How to handle merging then? This is a big question to me too. With reader pooling, if you open a reader and then it gets included in a merge, we'll reuse the same `SegmentReader` and its existing open index inputs, which have likely been open with a `NORMAL` or `RANDOM` advice. Ideally there would be a way for our `getMergeInstance()` APIs to somehow return a clone that has a different read advice. > It is good that IOContext with MergeInfo always requires SEQUENTIAL, but is this really used in all cases when we merge? My understanding is that it will only be used if the index input is created with the `IOContext` that is set on the `SegmentReadState` and this reader has been open specifically for merging, said otherwise the index has not been reopened between the time when the segment got written and the time when the same segment got merged away. This is only going to cover a small subset of the segments that we write, this doesn't look good enough to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
