uschindler commented on PR #13216: URL: https://github.com/apache/lucene/pull/13216#issuecomment-2020751491
> > we now use ChecksumIndexInput as the file is fully readonce without seeking. Because we removed the IOContext from directory's open method (as it is hardcoded to readOnce), we do not need to change the existing IOContext, so the modifier method can go away > > This is correct. > > > the file is then read in whole and closed, the FST is on-heap. > > Correct as well. > > > We do not have backwards compatibility here as it is not the default format, so we can change it in main branch (10.x). This won't be backported, correct? > > I don't believe that we attempt to not break non-default formats in minor releases, I have broken a few of them in the past in a minor. That said, I'm fine with not backporting, we could still have the `IOContext` ctor removed on 9.x by hardcoding `IOContext.READONCE` when opening the `IndexInput`. That's fine. Hardcoding READONCE is also fine for this case, because the MergeContext is not needed at all. We should at least add a note that the format has changed and older indexes can't be read. > For reference, I bumped the version number to make sure users get an `IndexFormatTooOldException` rather than a cryptic corruption exception. Of course, I understood that. Although we provide no backwards compatibility we should always change version numbers when format changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
