wardle commented on issue #11041: URL: https://github.com/apache/lucene/issues/11041#issuecomment-2018982902
Hi all. There is a small overhead with using CollectorManager over Collector. In my own usage, I have a read-only index which uses only a single slice, and I've chosen not to provide an executor service because my usage uses lots of cores for concurrent requests. Consequently, it seems to be that this is more of an issue of documentation, and best practices. Additional usage information in IndexSearcher#search to point users to use a CollectorManager might well suffice, and prevent what is presumably a concern about incorrect usage, while permitting users who know the nature of their index, and their usage patterns, to leverage the APIs as they need. Clearly, it is trivial to use CollectorManager and wrap my existing (custom) Collector, but it is an unnecessary overhead, albeit a very small one, but at the cost of losing backwards compatibility and with little gain as fundamentally both could co-exist without complication, but documentation steering most users to prefer CollectorManager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
