strainu commented on code in PR #12172:
URL: https://github.com/apache/lucene/pull/12172#discussion_r1537424935


##########
lucene/analysis/common/src/resources/org/apache/lucene/analysis/ro/stopwords.txt:
##########
@@ -190,27 +207,34 @@ sale
 sau
 său
 se
+și
 şi
 sînt
 sîntem
+sînteți

Review Comment:
   I don't know enough about how Lucene is used at large to understand whether 
there would be a difference between a search for `noi suntem romani` vs `noi 
suntem români` vs `noi santem romani` vs `noi sântem romani` vs `noi sântem 
români` vs `noi suntem români` (`romani` means `Romans`, `români` means 
`Romanians`). I would recommend we leave this for another PR though, as the 
current one only tries to solve the technical problems related to S comma-below 
vs cedilla-below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to