uschindler commented on issue #13194: URL: https://github.com/apache/lucene/issues/13194#issuecomment-2009709463
We can fold it in, but make it optional. Mike's investigation is fine but not the only truth. Circumventing OS cache is not always a good idea and you should only carefully do it for some use cases, not by default. If Elasticsearch or Dole wants to do this, ok. But lower level lucene should have all options. I would like it more to maybe move the directory to Lucene core and make the FSDirecory#open factory use it if it is supported by filesystem and JVM (the reflection hack!). Not sure how to detect if it's supported by filesystem without actually opening a file. 🤨 Finally, my personal opinion is to keep everything as is. We also do not fold NRTCachingDirectory into FSDirectory? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
