antonha commented on PR #13149: URL: https://github.com/apache/lucene/pull/13149#issuecomment-1999304142
> That said, I wonder if this change is legal: `DocIdSetIterator` must return doc IDs in order, but it looks like it wouldn't always be the case with your change? You are correct - I had (falsely) assumed that the document ids in the DocIdsWriter were written in order - thus the PR as of now (`dacb2a5d3ad707a555ed1fa2925a082d81aa4443`) is not a legal change. The good news is that this should not have affected the benchmarks - neither the `PointRangeQuery` nor the `NumericLeafComparator` seems to rely on the DISI being ordered. They just iterate until `DocIdSetIterator.NO_MORE_DOCS`. I will try adding a `visit()` method taking an IntsRef (I believe that is what you meant @jpountz?). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
