tteofili commented on code in PR #13119:
URL: https://github.com/apache/lucene/pull/13119#discussion_r1495629501
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java:
##########
@@ -111,6 +112,8 @@
* <li>0: EUCLIDEAN distance. ({@link
VectorSimilarityFunction#EUCLIDEAN})
* <li>1: DOT_PRODUCT similarity. ({@link
VectorSimilarityFunction#DOT_PRODUCT})
* <li>2: COSINE similarity. ({@link VectorSimilarityFunction#COSINE})
+ * <li>3: MAXIMUM_INNER_PRODUCT similarity. ({@link
+ * VectorSimilarityFunction#MAXIMUM_INNER_PRODUCT})
Review Comment:
probably it'd make sense to do it in a different PR, for easier tracking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
