easyice commented on PR #13104: URL: https://github.com/apache/lucene/pull/13104#issuecomment-1946004282
Thank you for the great suggestions! @uschindler You are right, all the setters are used after the construction only, It makes sense if they are only set on construction. The only thing to consider is the impact of API changes to the users. for the time being I follow the @rmuir 's suggestion, move this check to `setTokenType`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
