uschindler commented on PR #13068: URL: https://github.com/apache/lucene/pull/13068#issuecomment-1945649280
To the other reviewers: I would like to merge this as a first step. To me this looks fine as it removes the code duplication and we have a better method name. Ok? If we remove the static method and instead use `toString()` for that, should possibly another issue. I like the discussion started by @mikemccand and @dweiss. I plan to merge this late afternoon German time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
