dweiss commented on PR #13075: URL: https://github.com/apache/lucene/pull/13075#issuecomment-1926938848
> Looks fine. Why did you create a `Function<String,LocalDateTime>` for parsing instead of a simple static method? I think you did this to hide the formatter instances? Yes, correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
