mayya-sharipova commented on code in PR #12962:
URL: https://github.com/apache/lucene/pull/12962#discussion_r1473008106
##########
lucene/core/src/java/org/apache/lucene/index/LeafReader.java:
##########
@@ -280,12 +289,20 @@ public final TopDocs searchNearestVectors(
* @param k the number of docs to return
* @param acceptDocs {@link Bits} that represents the allowed documents to
match, or {@code null}
* if they are all allowed to match.
- * @param visitedLimit the maximum number of nodes that the search is
allowed to visit
+ * @param visitedLimit the maximum number of nodes that the search is
allowed to visit *@param
+ * globalScoreQueue the global score queue used to track the top scores
collected across all
+ * leaves
* @return the k nearest neighbor documents, along with their
(searchStrategy-specific) scores.
* @lucene.experimental
*/
public final TopDocs searchNearestVectors(
- String field, byte[] target, int k, Bits acceptDocs, int visitedLimit)
throws IOException {
+ String field,
+ byte[] target,
+ int k,
+ Bits acceptDocs,
+ int visitedLimit,
+ BlockingFloatHeap globalScoreQueue)
+ throws IOException {
Review Comment:
Addressed in the last commit
##########
lucene/core/src/java/org/apache/lucene/index/LeafReader.java:
##########
@@ -280,12 +289,20 @@ public final TopDocs searchNearestVectors(
* @param k the number of docs to return
* @param acceptDocs {@link Bits} that represents the allowed documents to
match, or {@code null}
* if they are all allowed to match.
- * @param visitedLimit the maximum number of nodes that the search is
allowed to visit
+ * @param visitedLimit the maximum number of nodes that the search is
allowed to visit *@param
+ * globalScoreQueue the global score queue used to track the top scores
collected across all
+ * leaves
* @return the k nearest neighbor documents, along with their
(searchStrategy-specific) scores.
* @lucene.experimental
*/
public final TopDocs searchNearestVectors(
- String field, byte[] target, int k, Bits acceptDocs, int visitedLimit)
throws IOException {
+ String field,
+ byte[] target,
+ int k,
+ Bits acceptDocs,
+ int visitedLimit,
+ BlockingFloatHeap globalScoreQueue)
+ throws IOException {
Review Comment:
Addressed in the last commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
