uschindler commented on PR #13052: URL: https://github.com/apache/lucene/pull/13052#issuecomment-1915775381
I am not sure if I like this code. Unfortunately the spec of `Set#removeAll()` is a bit stupid and should only use `argument.contains()` if it is a set (so almost constant contains is possible). I'd like to ask to open a bug in OpenJDK so this gets fixed at some point. Did you make a benchmarking if this affects Lucene at all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
