mikemccand commented on PR #12966: URL: https://github.com/apache/lucene/pull/12966#issuecomment-1890455264
> I found a fun HeisenBug in one of the tests. Oh the joys of floating point math. > For those who want to follow along, here are the exact numbers we are adding in the test in two orderings which produce different results: Thank you for diving deep here and making such a simple reproduction. > how should I interpret the other tasks which show a significant change? Are they just noisy? Good question -- it makes no sense that e.g. `Respell/Fuzzy1/2` got faster with this change, though the benchy seems to think it is significant (`p=0.000`). I'm not sure what to make of it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
