mikemccand commented on PR #12966: URL: https://github.com/apache/lucene/pull/12966#issuecomment-1880935940
> 3\. Is it important to preserve a default aggregation value of the right type in the results (i.e. `-1` for int aggregations, `-1f` for float aggregations)? If not, we can make a small simplification to always return `-1`. Maybe defer this to a separate issue? I can see callers expecting a consistent type, though, if you cast `(float) Number` where `Number` is an int, the cast would be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
