easyice commented on PR #12997:
URL: https://github.com/apache/lucene/pull/12997#issuecomment-1882374457

   > another approach could consist of filling at most docFreq entries in the 
freq buffer
   
   It's a nice idea!
   
   > I didn't know we had such leniency around frequencies/positions/offsets.
   
   Yes, It feels like it should be more clear.
   
   
   I found there is a big different speedup between java versions, the 
benchmark shows a significant speedup on java17, but only 3% on java21
   
   **java17:**
   ```
       TaskQPS baseline      StdDevQPS my_modified_version      StdDev          
      Pct diff p-value
   PKLookup       89.14     (10.0%)      104.32      (9.1%)   17.0% (  -1% -   
40%) 0.000               
   ```
   
   **java21:**
   ```
       TaskQPS baseline      StdDevQPS my_modified_version      StdDev          
      Pct diff p-value
   PKLookup      113.20     (11.9%)      116.58     (10.7%)    3.0% ( -17% -   
28%) 0.402
   ```
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to