heemin32 commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1881932572
There are existing tests which should fails. https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java#L67 However because we are catching exception and try until we get the correct polygon, it never fails. https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/document/BaseXYShapeTestCase.java#L228-L235 I cannot remove the try-catch statement as of now because there are bug in `surpriseMePolygon()` and `createRegularPolygon()` which fails to create a valid polygon because of type casting from double to float. One of attempt to fix it is in https://github.com/apache/lucene/pull/12757. I would like to wait until the other issues are resolved and remove the try-catch statement rather than writing a unit test for just the test utility code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
