mikemccand commented on code in PR #12879:
URL: https://github.com/apache/lucene/pull/12879#discussion_r1441950879
##########
lucene/core/src/java/org/apache/lucene/util/fst/ReadWriteDataOutput.java:
##########
@@ -56,14 +66,59 @@ public long ramBytesUsed() {
public void freeze() {
frozen = true;
- // this operation are costly, so we want to compute it once and cache
- dataInput = dataOutput.toDataInput();
+ // this operation is costly, so we want to compute it once and cache
+ this.byteBuffers = dataOutput.toWriteableBufferList();
}
@Override
public FST.BytesReader getReverseBytesReader() {
- assert dataInput != null; // freeze() must be called first
- return new ReverseRandomAccessReader(dataInput);
+ assert byteBuffers != null; // freeze() must be called first
+ if (byteBuffers.size() == 1) {
+ // use a faster implementation for single-block case
+ return new ReverseBytesReader(byteBuffers.get(0).array());
Review Comment:
Yeah I realize the code is safe but it takes some thinking to confirm it --
maybe add the assert with your awesome above explanation? So future code
readers know why this `ByteBuffer` is for sure backed by an array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
