easyice commented on PR #12841: URL: https://github.com/apache/lucene/pull/12841#issuecomment-1871203007
Yeah, i backport this PR to branch_9x on my local machine, and run the benchmark with java11, i got performance regression for `MMapDirectoryInputs`, even if we not change the code for `ByteBufferIndexInput` :( java11 ``` Benchmark (size) Mode Cnt Score Error Units GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVInt 64 thrpt 5 5.064 ± 0.069 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVIntBaseline 64 thrpt 5 1.612 ± 0.078 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVInt 64 thrpt 5 6.334 ± 0.914 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 7.362 ± 0.505 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readVInt 64 thrpt 5 4.885 ± 0.545 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVInt 64 thrpt 5 2.977 ± 0.346 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 2.660 ± 1.700 ops/us ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
