s1monw commented on PR #12829: URL: https://github.com/apache/lucene/pull/12829#issuecomment-1862391122
@mikemccand @jpountz I updated this PR and moved everything to FielInfo / IWC. I think it's ready. the only thing that I'd like to discuss is that we are currently recording the number of children in the DV field. I don't think we should do that unless we have a good reason. Instead i'd like to index `-1` into it to keep that for a later version of lucene if we have a reason for it. that would also make this field essentially a bitset on the DV codec end. From a testing perspective, I 'd like to enable this randomly in `RIW` but that requires some changes and I'd rather do that in a followup which is easier to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
