benwtrent commented on code in PR #12943:
URL: https://github.com/apache/lucene/pull/12943#discussion_r1426804219
##########
lucene/core/src/test/org/apache/lucene/index/TestKnnGraph.java:
##########
@@ -100,22 +100,18 @@ public KnnVectorsFormat
getKnnVectorsFormatForField(String field) {
}
};
- if (vectorEncoding == VectorEncoding.FLOAT32) {
- float32Codec = codec;
Review Comment:
@msokolov yeah, two tests are really relying on perfect scores & things
being float. I mistakenly turned on quantization which adds some error bands to
the scores (obviously, because its lossy) and thus its flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
