slow-J commented on issue #7721: URL: https://github.com/apache/lucene/issues/7721#issuecomment-1854443688
> If this has been open for 8 years, yet we have never had an NPE resulting from missing these checks, then I think we can concluded the checks are not needed. As a rule, we only need null checks where we expect null values. If we get an unexpected null value, we _want_ an unexpected exception so we can find the root cause. So I don't think we should merge this. Thanks for the info @msokolov, that makes sense! If we close this issue, I can cancel the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
