uschindler commented on issue #12931: URL: https://github.com/apache/lucene/issues/12931#issuecomment-1854281422
To give a bit of context: I would also add ZWNJ (and if I do, 3 tests trigger the validation violation). But Robert does not like it because he wants to write tests without escapes. I don't agree with that, but I don't want to argue. To me the more important one is ZWSP (U+200B), because when you copy-paste code from javadocs generated by the javadoc tool, there are U+200B between method names and parameters, so it happens easily that you get them into code. This happened to me in the `ExtractJdkApis.java` file used by Gradle to generate API signature files. So my PR #12937 just catches this one for now. In addition I added validation of the UTF-8 encoding, so files saved accidentally as ISO-8859-x are detected by `./gradlew validateSourcePatterns`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
