uschindler commented on issue #12911: URL: https://github.com/apache/lucene/issues/12911#issuecomment-1852647559
> > > There is no easy way to fail the build, because the FST files are heavy to generate and stay in the resources folder. It is hard to detect a problem if you don't regenerate them, which we won't do by default (as it needs to download external files). > > > > > > I wonder if we could do it in the code rather than in the build, e.g. by checking that `version == VERSION_CURRENT` on `FSTMetadata` for all FSTs that we load from a Lucene JAR? > > I'll try this approach. I'm not sure how to do it at such a low level as "loading resources from Lucene jar that look like FSTs" ... I'll start just checking the two known binary FSTs we ship today (Nori, Kuromoji). You can't add such special checks without adding a specific method to load from jar files. But this must be avoided, as it is caller sensitive regarding module system. So please do not add utility methods to load fsr from classpath as it could be module resources. So just check after loading that version is the expected one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
