dungba88 commented on code in PR #12885:
URL: https://github.com/apache/lucene/pull/12885#discussion_r1423374521
##########
lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseReadingFormFilter.java:
##########
@@ -88,6 +88,11 @@ protected TokenStreamComponents createComponents(String
fieldName) {
a.close();
}
+ public void testKatakanaReadingsHiragana() throws IOException {
+ assertAnalyzesTo(
+ katakanaAnalyzer, "が ぎ ぐ げ ご ぁ ゔ", new String[] {"ガ", "ギ", "グ", "ゲ",
"ゴ", "ァ", "ヴ"});
Review Comment:
I'm wondering what would happen if these characters are in decomposed form?
It seems like the か part will be converted to カ but the dakuten is not. Maybe
we could have test to see how it looks like?
##########
lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseReadingFormFilter.java:
##########
@@ -88,6 +88,11 @@ protected TokenStreamComponents createComponents(String
fieldName) {
a.close();
}
+ public void testKatakanaReadingsHiragana() throws IOException {
+ assertAnalyzesTo(
+ katakanaAnalyzer, "が ぎ ぐ げ ご ぁ ゔ", new String[] {"ガ", "ギ", "グ", "ゲ",
"ゴ", "ァ", "ヴ"});
Review Comment:
I'm wondering what would happen if these characters are in decomposed form?
It seems like the か part will be converted to カ but the dakuten is not. Maybe
we could have test to see how it looks like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
