mikemccand commented on PR #12908: URL: https://github.com/apache/lucene/pull/12908#issuecomment-1850117651
> It's actually a bad news that all tests pass here, as this means that our `BasePostingsFormatTestCase` is not good enough to uncover the recent problem with `Terms#intersect`... So we could add a similar bug in the future, and we'd only learn about it after releasing when @mikemccand 's new bw compat test from #12901 starts running? Well, at least for this particular `Terms.intersect` bug (#12895), the bug only exists when 9.9.0 reads <= 9.8 written indices, i.e. the bug is sidestepped when 9.9.0 reads 9.9.0 written indices because of the separate LSB -> MSB `writeVLong` change. It masks/prevents the read-time bug entirely. So there is / was no hope for `BasePostingsFormatTestCase` to catch this hidden / lurking bug, I fear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
