mikemccand commented on issue #12901: URL: https://github.com/apache/lucene/issues/12901#issuecomment-1849968380
> We should look into more systematically forking the code when we do a file format change, or figuring out other ways to keep testing prior formats with version bumps, e.g. by retaining version checks on the write side and making sure there is a separate `BasePostingsFormatTestCase` impl for every version number? +1 -- normally forking/duplicating code is a bad thing, but for BWC testing, and for code clarity and our sanity keeping track of code changes that correspond to our on-disk format changes, it is the lesser evil (to fork). And I think #12908 is a case-in-point showing how risky it is to try to add the right `if` statements on the write side -- the `precommit` failures there are subtle and I think maybe due to a missing `if` statement somewhere in the code changes... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
