gokaai commented on code in PR #12872: URL: https://github.com/apache/lucene/pull/12872#discussion_r1419439605
########## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ########## @@ -4270,11 +4290,21 @@ public int doCheck(Options opts) throws IOException, InterruptedException { + result.totLoseDocCount + " documents would be lost, if -exorcise were specified\n"); } else { - opts.out.println("WARNING: " + result.totLoseDocCount + " documents will be lost\n"); - opts.out.println( - "NOTE: will write new segments file in 5 seconds; this will remove " - + result.totLoseDocCount - + " docs from the index. YOU WILL LOSE DATA. THIS IS YOUR LAST CHANCE TO CTRL+C!"); + if (result.numBadSegmentsWithoutSegmentInfo > 0) { + opts.out.println( + "WARNING: " + result.totLoseDocCount + " or more documents will be lost\n"); Review Comment: Makes sense! Will rephrase as 'at least' in all occurrences -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org