stefanvodita commented on code in PR #12854:
URL: https://github.com/apache/lucene/pull/12854#discussion_r1419296316
##########
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##########
@@ -133,7 +133,12 @@ public DrillSideways(
/**
* Subclass can override to customize drill down facets collector. Returning
{@code null} is valid
* if no drill down facet collection is needed.
+ *
+ * @deprecated This is only used by the deprecated {@link
#search(DrillDownQuery, Collector)}
Review Comment:
Maybe I'm competely missing it, but I only see a `search` with
`CollectorManager` in `DrillSideways`
([code](https://github.com/apache/lucene/blob/b6999818474c518953d1290ef304c84dedb04ab6/lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java#L349)),
not one with `Collector`. Was it already deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
