benwtrent commented on PR #12857: URL: https://github.com/apache/lucene/pull/12857#issuecomment-1836748924
Is our goal memory usage or speed? We could use `FixedBitSet#intersectionCount` and keep from having to create a new bit set that is the intersection. I am honestly not sure if the implementation here is any faster than just creating the bit set upfront and checking it. During search, you now have to check two bitsets now instead of one. If the filter happens to be `< number of docs visited in a typical search`, your implementation here seems like it would be slower. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
