mikemccand commented on code in PR #12847: URL: https://github.com/apache/lucene/pull/12847#discussion_r1408286029
########## lucene/CHANGES.txt: ########## @@ -176,7 +178,8 @@ API Changes * GITHUB#12799: Make TaskExecutor constructor public and use TaskExecutor for concurrent HNSW graph build. (Shubham Chaudhary) -* +* GITHUB#12758, GITHUB#12803: Remove FST constructor with DataInput for metadata. Please Review Comment: Ahh are you adding the missing 9.9 CHANGES.txt entries for recent FST changes here? Great! ########## lucene/CHANGES.txt: ########## @@ -246,6 +249,8 @@ Improvements minimal FST. Inspired by this Rust FST implemention: https://blog.burntsushi.net/transducers (Mike McCandless) +* GITHUB#12738: NodeHash now stores the FST nodes data instead of just node addresses (Anh Dung Bui) Review Comment: And here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org